Skip to content

Integration of USB-stick#117

Merged
CoMPaTech merged 60 commits intomasterfrom
plugwise-stick
Oct 15, 2020
Merged

Integration of USB-stick#117
CoMPaTech merged 60 commits intomasterfrom
plugwise-stick

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech commented Sep 21, 2020 •
edited
Loading

Internal testing PR for integrating Plugwise Stick into HA Plugwise brand-integration. See #116 for the todolist

@CoMPaTech
Copy link
Copy Markdown
Member Author

CoMPaTech commented Sep 21, 2020 •
edited
Loading

Looks like shifting async_setup_entry works - though this isn't integration by any means yet. Leaving it at that for now until we can have some idea of 116's ideas make sense (i.e. then we can continue this path of splitting off network first before adding usb).

@CoMPaTech CoMPaTech added enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core labels Sep 21, 2020
@CoMPaTech CoMPaTech linked an issue Sep 21, 2020 that may be closed by this pull request
[FEATURE] Integrate Plugwise-stick #116
Closed
@CoMPaTech CoMPaTech marked this pull request as draft September 21, 2020 20:16
@CoMPaTech CoMPaTech mentioned this pull request Sep 27, 2020
Closed
@CoMPaTech CoMPaTech changed the title Lets give it a try Attempt at initial integration of USB-stick Sep 27, 2020
@CoMPaTech
Copy link
Copy Markdown
Member Author

CoMPaTech commented Sep 30, 2020

@brefra could you have a look if the initial flow 'sort of works' for you? From there we could move forward and have a look at switch.py etc.

@CoMPaTech
Copy link
Copy Markdown
Member Author

CoMPaTech commented Oct 3, 2020

Switched 'merged' in (as in duplicate code, but ability to handle can be tested).

From there we can make an effort to use a single SwitchEntity or keep it as is (two codestreams). As indicated in the issue I'm only able to test that the primary function of the integration still works, having no plugs (nor something to talk to them) I'm not able to beta-test this.

@CoMPaTech CoMPaTech mentioned this pull request Oct 4, 2020
Merged
18 tasks
@CoMPaTech
Copy link
Copy Markdown
Member Author

CoMPaTech commented Oct 4, 2020 •
edited
Loading

Initial separation PR home-assistant/core#41201 created for HA-Core. Tests by @bouwew look promising (re-use of the USB stick natively).

@CoMPaTech CoMPaTech changed the title Attempt at initial integration of USB-stick Initial integration of USB-stick (config-flow and switch-platform) Oct 4, 2020
This was referenced Oct 4, 2020
Merged
Merged
@bouwew bouwew changed the title Initial integration of USB-stick (config-flow and switch-platform) Integration of USB-stick Oct 14, 2020
@CoMPaTech CoMPaTech requested review from bouwew and brefra October 15, 2020 18:08
CoMPaTech
CoMPaTech commented Oct 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member Author

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (can't approve as designated PR author)

bouwew
bouwew approved these changes Oct 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, looking good :)

@brefra
Copy link
Copy Markdown
Contributor

brefra commented Oct 15, 2020

LGTM too 🙂

@CoMPaTech
Copy link
Copy Markdown
Member Author

CoMPaTech commented Oct 15, 2020

There we go!

@CoMPaTech CoMPaTech merged commit 4368ccc into master Oct 15, 2020
@bouwew bouwew deleted the plugwise-stick branch October 21, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brefra brefra brefra approved these changes

@bouwew bouwew bouwew approved these changes

Assignees

@CoMPaTech CoMPaTech

@brefra brefra

@bouwew bouwew

Labels

enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Integrate Plugwise-stick

3 participants

@CoMPaTech @brefra @bouwew